Skip to content

gh-146080: fix a crash in SNI callbacks when the SSL object is gone#146573

Merged
picnixz merged 2 commits intopython:mainfrom
picnixz:fix/ssl/servername-callback-146080
Mar 29, 2026
Merged

gh-146080: fix a crash in SNI callbacks when the SSL object is gone#146573
picnixz merged 2 commits intopython:mainfrom
picnixz:fix/ssl/servername-callback-146080

Conversation

@picnixz
Copy link
Copy Markdown
Member

@picnixz picnixz commented Mar 28, 2026

@picnixz
Copy link
Copy Markdown
Member Author

picnixz commented Mar 28, 2026

Urgh, I think the mnemonics are different on AWS-LC -_-. So OBVIOUSLY, my message will be different.

@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 28, 2026
@bedevere-bot
Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit d8911ce 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146573%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 28, 2026
@picnixz picnixz merged commit 24db78c into python:main Mar 29, 2026
115 of 127 checks passed
@miss-islington-app
Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

Sorry, @picnixz, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 24db78c5329dd405460bfdf76df380ced6231353 3.14

@picnixz picnixz deleted the fix/ssl/servername-callback-146080 branch March 29, 2026 12:27
@miss-islington-app
Copy link
Copy Markdown

Sorry, @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 24db78c5329dd405460bfdf76df380ced6231353 3.13

@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 29, 2026

GH-146597 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 29, 2026
picnixz added a commit to picnixz/cpython that referenced this pull request Mar 29, 2026
…ect is gone (pythonGH-146573)

(cherry picked from commit 24db78c)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit to picnixz/cpython that referenced this pull request Mar 29, 2026
…ect is gone (pythonGH-146573)

(cherry picked from commit 24db78c)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Mar 29, 2026

GH-146598 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 29, 2026
picnixz added a commit that referenced this pull request Mar 29, 2026
picnixz added a commit that referenced this pull request Mar 29, 2026
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 30, 2026
…ktor

* upstream/main: (119 commits)
  pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845)
  pythongh-146558: JIT optimize dict access for objects with known hash (python#146559)
  pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570)
  pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631)
  pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593)
  pythongh-138122: Add differential flame graph (python#145785)
  pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417)
  pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628)
  pythongh-138850: Add --disable-epoll to configure (pythonGH-145768)
  pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624)
  pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597)
  pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557)
  pythongh-146579: _zstd: Fix decompression options dict error message (python#146577)
  pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085)
  pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573)
  pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569)
  pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472)
  pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580)
  pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004)
  pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants