gh-146587: fix type slot assignment incase of multiple slots for same name#146593
gh-146587: fix type slot assignment incase of multiple slots for same name#146593kumaraditya303 wants to merge 6 commits intopython:mainfrom
Conversation
|
@kumaraditya303 Could you please take a look at sergey-miryanov@f26545a? WDYT? |
It looks the same as this one except more complicated, you are also checking that if a slot has duplicates then only one of them should be filled isn't it? I am not sure that the loop is big enough that there would be performance difference. |
|
Yeah, it looks the same. Except we don’t need to iterate all slotdefs, because we precalculates dup indexes. |
|
I wrote answer before your edit. I don’t remember exactly how items in slotdefs, about |
Alright, I implemented your suggestion. |
|
Thanks! |
__radd__fallback regression #146587