Open
Conversation
dosubot
bot
added
size:XL
mr-cheffy
requested changes
Mar 12, 2026
mr-cheffy
requested changes
Mar 12, 2026
src/browser/components/urlbar/content/enUS-searchFeatures-ftl.patch
Outdated
Show resolved
Hide resolved
SilverEzhik
force-pushed
the
spaces-search
branch
2 times, most recently
from
60304a2 to
455a5b4
Compare
SilverEzhik
force-pushed
the
spaces-search
branch
from
455a5b4 to
0783f6a
Compare
mr-cheffy
requested changes
Mar 21, 2026
Member
mr-cheffy
left a comment
mr-cheffy
left a comment
There was a problem hiding this comment.
Please dont do text for other languages
Author
|
Alright, removed all except for en-US. |
dosubot
bot
added
size:L
mr-cheffy
requested changes
Mar 26, 2026
| + source: this.RESULT_SOURCE.WORKSPACES, | ||
| + restrict: lazy.UrlbarTokenizer.RESTRICT.WORKSPACE, | ||
| + icon: "chrome://browser/skin/zen-icons/selectable/layers.svg", | ||
| + pref: "shortcuts.workspaces", |
Member
There was a problem hiding this comment.
The pref should probably be added into zen-urlbar.yml, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope a drive-by PR is alright.
This PR implements a dedicated search shortcut, bound to ` (backtick).
Zen already has support for spaces search, but it's implemented on the actions search mode. This PR introduces a new search mode for spaces, activated with a special key, similar to Firefox's existing tabs/bookmarks/history search shortcuts.
I was originally considering
~instead of `, but that interferes with resolving to the user's home directory. On Mac, at least, using ` does not interfere with theOpt-` dead key combo for typing à and such, but would appreciate additional tests for this one. The backtick is missing on some keyboard layouts, but so are Firefox's existing keys, such as^.Since actions search mode already had support for workspace search, I've opted to factor out the common bits (specifically, fuzzy search and presenting search results) into a common helper, which is used by both search modes.