fix(academy): hide academy pages until content is ready#3839
fix(academy): hide academy pages until content is ready#3839waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Removes user entry points by commenting out the Written by Cursor Bugbot for commit 1a55f6e. Configure here. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1a55f6e to
5bcdfb6
Compare
Greptile SummaryThis PR hides all
Confidence Score: 5/5Safe to merge — the 404 guard is correctly implemented and all remaining findings are P2 quality/UX suggestions. Both findings are P2: the dead-end CTA section is a minor UX concern that won't cause errors, and the hardcoded flag vs env var is a developer convenience suggestion. Neither blocks merge. apps/sim/app/(landing)/partners/page.tsx — the bottom CTA section still renders Academy text without a button. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User visits /academy/*] --> B{ACADEMY_ENABLED?}
B -- false --> C[notFound called]
C --> D[Next.js 404 page]
B -- true --> E[AcademyLayout renders children]
E --> F[Academy page content]
G[User visits /partners] --> H[PartnersPage renders]
H --> I[Hero section]
I -- Start Sim Academy button commented out --> J[Only Learn more anchor shown]
H --> K[Bottom CTA section]
K -- button commented out --> L[Section renders Academy text but no button]
M[Footer Resources column] --> N[Academy link commented out]
N --> O[Link not rendered]
|
Summary
/academy/*routes by adding anACADEMY_ENABLEDflag in the root academy layout that callsnotFound()when disabledTest plan
/academy— should show 404/academy/sim-foundations— should show 404/partnerspage — no "Start Sim Academy" buttons visible