fix(viewer): image pan/zoom, sort fixes, sidebar dot fixes#3836
fix(viewer): image pan/zoom, sort fixes, sidebar dot fixes#3836waleedlatif1 merged 4 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Fixes a document chunks sorting bug by mapping the Hides sidebar task status dots while the task context menu is open to avoid visual overlap/confusion. Written by Cursor Bugbot for commit e48ec43. Configure here. |
Greptile SummaryThis PR bundles four targeted fixes across the workspace UI:
Confidence Score: 5/5Safe to merge — all changes are well-scoped bug fixes and a contained new feature with no P0/P1 issues. All four changes are minimal and targeted. The two previously flagged issues in the image viewer (unconditional preventDefault and zoom-button drag bubbling) are confirmed resolved. The sort key fix, infinite-scroll guard, and sidebar dot visibility change are all correct and low-risk. No remaining findings rise above P2. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "fix(file-viewer): use exponential zoom f..." | Re-trigger Greptile |
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer.tsx
Show resolved
Hide resolved
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer.tsx
Outdated
Show resolved
Hide resolved
|
Good catches — both fixed in 5e7e979:
|
waleedlatif1
left a comment
There was a problem hiding this comment.
Both issues fixed in 5e7e979 — e.preventDefault() now applies to all wheel events (not just ctrl/meta), and the zoom controls wrapper has onMouseDown stopPropagation to block micro-pans.
|
@greptile |
|
@cursor review |
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer.tsx
Outdated
Show resolved
Hide resolved
|
@greptile |
|
@cursor review |
Summary
Type of Change
Testing
Tested manually
Checklist