Skip to content

fix(knowledge): reject non-alphanumeric file extensions from document names #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Mar 27, 2026
+8 −7
Merged

fix(knowledge): reject non-alphanumeric file extensions from document names #3816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c824a2
fix(knowledge): reject non-alphanumeric file extensions from document…
waleedlatif1 Mar 27, 2026
ce71ebf
fix(knowledge): improve error message when extension is non-alphanumeric
waleedlatif1 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apps/sim/lib/knowledge/documents/parser-extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ export function resolveParserExtension(
mimeType?: string,
fallback?: string
): string {
const filenameExtension = filename.includes('.')
? filename.split('.').pop()?.toLowerCase()
: undefined
const raw = filename.includes('.') ? filename.split('.').pop()?.toLowerCase() : undefined
const filenameExtension = raw && /^[a-z0-9]+$/.test(raw) ? raw : undefined

if (filenameExtension && isSupportedParserExtension(filenameExtension)) {
return filenameExtension
Expand Down
10 changes: 6 additions & 4 deletions apps/sim/lib/uploads/utils/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,13 @@ export interface FileValidationError {
* Validate if a file type is supported for document processing
*/
export function validateFileType(fileName: string, mimeType: string): FileValidationError | null {
const extension = path.extname(fileName).toLowerCase().substring(1) as SupportedDocumentExtension
const raw = path.extname(fileName).toLowerCase().substring(1)
const extension = (/^[a-z0-9]+$/.test(raw) ? raw : '') as SupportedDocumentExtension

if (!SUPPORTED_DOCUMENT_EXTENSIONS.includes(extension)) {
return {
code: 'UNSUPPORTED_FILE_TYPE',
message: `Unsupported file type: ${extension}. Supported types are: ${SUPPORTED_DOCUMENT_EXTENSIONS.join(', ')}`,
message: `Unsupported file type${extension ? `: ${extension}` : ` for "${fileName}"`}. Supported types are: ${SUPPORTED_DOCUMENT_EXTENSIONS.join(', ')}`,
supportedTypes: [...SUPPORTED_DOCUMENT_EXTENSIONS],
}
}
Expand Down Expand Up @@ -221,15 +222,16 @@ export function validateMediaFileType(
fileName: string,
mimeType: string
): FileValidationError | null {
const extension = path.extname(fileName).toLowerCase().substring(1)
const raw = path.extname(fileName).toLowerCase().substring(1)
const extension = /^[a-z0-9]+$/.test(raw) ? raw : ''

const isAudio = SUPPORTED_AUDIO_EXTENSIONS.includes(extension as SupportedAudioExtension)
const isVideo = SUPPORTED_VIDEO_EXTENSIONS.includes(extension as SupportedVideoExtension)

if (!isAudio && !isVideo) {
return {
code: 'UNSUPPORTED_FILE_TYPE',
message: `Unsupported media file type: ${extension}. Supported audio types: ${SUPPORTED_AUDIO_EXTENSIONS.join(', ')}. Supported video types: ${SUPPORTED_VIDEO_EXTENSIONS.join(', ')}`,
message: `Unsupported media file type${extension ? `: ${extension}` : ` for "${fileName}"`}. Supported audio types: ${SUPPORTED_AUDIO_EXTENSIONS.join(', ')}. Supported video types: ${SUPPORTED_VIDEO_EXTENSIONS.join(', ')}`,
supportedTypes: [...SUPPORTED_AUDIO_EXTENSIONS, ...SUPPORTED_VIDEO_EXTENSIONS],
}
}
Expand Down
Loading