Skip to content

PEP 583: Fix Sphinx warnings#4808

Open
Secrus wants to merge 1 commit intopython:mainfrom
Secrus:pep-583-footnotes
Open

PEP 583: Fix Sphinx warnings#4808
Secrus wants to merge 1 commit intopython:mainfrom
Secrus:pep-583-footnotes

Conversation

@Secrus
Copy link
Copy Markdown
Contributor

@Secrus Secrus commented Feb 3, 2026

Ref: #4087

The search for changes removing the references was done with: git log --follow -S "<ref.footnote>" -p -- peps/pep-0583.rst.

I have verified that PEP 583 generates no warnings on Sphinx v8.1.3.


📚 Documentation preview 📚: https://pep-previews--4808.org.readthedocs.build/

@Secrus Secrus marked this pull request as ready for review February 3, 2026 21:04
@Secrus Secrus requested a review from a team as a code owner February 3, 2026 21:04
---------------------------------------------------------------

From the POPL paper about the Java memory model [#JMM-popl].
From the POPL paper about the Java memory model [#JMM-popl]_.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, there's another ill-formed reference to this footnote on line 367.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Secrus Please could you fix that one too?

---------------------------------------------------------------

From the POPL paper about the Java memory model [#JMM-popl].
From the POPL paper about the Java memory model [#JMM-popl]_.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Secrus Please could you fix that one too?

Comment on lines 787 to -814
@@ -804,15 +800,6 @@ References

.. [#slots] __slots__ (http://docs.python.org/ref/slots.html)

.. [#] Alternatives to SC, a thread on the cpp-threads mailing list,
which includes lots of good examples.
(http://www.decadentplace.org.uk/pipermail/cpp-threads/2007-January/001287.html)

.. [#safethread] python-safethread, a patch by Adam Olsen for CPython
that removes the GIL and statically guarantees that all objects
shared between threads are consistently
locked. (http://code.google.com/p/python-safethread/)
Copy link
Copy Markdown
Member

@hugovk hugovk Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you convert these three removed ones into bullet points at the end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants