gh-146615: Fix format specifiers in extension modules#146617
Draft
sunmy2019 wants to merge 1 commit intopython:mainfrom
Draft
gh-146615: Fix format specifiers in extension modules#146617sunmy2019 wants to merge 1 commit intopython:mainfrom
sunmy2019 wants to merge 1 commit intopython:mainfrom
Conversation
emmatyping
reviewed
Mar 30, 2026
| if (PyErr_ExceptionMatches(PyExc_OverflowError)) { | ||
| PyErr_Format(PyExc_ValueError, | ||
| "size argument should be a positive int less " | ||
| "than %ull", ZSTD_CONTENTSIZE_ERROR); |
Member
There was a problem hiding this comment.
Looks like this was duplicated from #146576. Serhiy asked to add a test in that pull request, so I'd say it'd be best to remove this here and keep the change separate.
| else { | ||
| if (PyUnicodeWriter_Format( | ||
| writer, "unknown error (0x%x)", errcode) < 0) { | ||
| writer, "unknown error (0x%lx)", errcode) < 0) { |
| default: | ||
| PyErr_Format(PyExc_ValueError, | ||
| "Unsupported TLS/SSL version 0x%x", v); | ||
| "Unsupported TLS/SSL version 0x%lx", v); |
Member
There was a problem hiding this comment.
We can use %#... here too.
I believe that the better fix is to change the type of v to int and update the parsing code above.
Also, cast v to an unsigned type explicitly.
| if (result == 0) { | ||
| PyErr_Format(PyExc_ValueError, | ||
| "Unsupported protocol version 0x%x", v); | ||
| "Unsupported protocol version 0x%lx", v); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.