gh-146448: fix t-string parser truncating expression at != with format spec#146614
Open
joshuaswanson wants to merge 1 commit intopython:mainfrom
Open
gh-146448: fix t-string parser truncating expression at != with format spec#146614joshuaswanson wants to merge 1 commit intopython:mainfrom
joshuaswanson wants to merge 1 commit intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146448.
The lexer treats
!inside f-string/t-string expressions as a conversion specifier marker, which causes the expression text to be truncated at!. For!=, this incorrectly setsInterpolation.strto just the part before!(e.g.t'{0!=0:}'producesstr='0'instead ofstr='0!=0'). The bug only triggers when a format spec follows (:) because without it, the expression end is determined by}instead.The fix peeks at the character following
!usingtok_nextc/tok_backupand only treats it as f-string punctuation when it's not followed by=.