-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
gh-146553: Fix infinite loop in typing.get_type_hints() on circular __wrapped__ #146554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
raminfp
wants to merge
4
commits into
python:main
from
raminfp:gh-146553-fix-get-type-hints-wrapped-cycle
+34
−14
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
61a821b
gh-146553: Fix infinite loop in typing.get_type_hints() on circular _…
raminfp 4e9afee
gh-146553: Use inspect.unwrap() for cycle detection instead of custom…
raminfp e205384
gh-146553: Use _lazy_load_unwrap() helper instead of local import in …
raminfp 27c948d
gh-146553: Replace _lazy_load_* helpers with _LazyInspect for lazy in…
raminfp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Library/2026-03-28-11-43-25.gh-issue-146553.mXaWza.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Fix :func:`typing.get_type_hints` hanging indefinitely when a callable has a | ||
| circular ``__wrapped__`` chain (e.g. ``f.__wrapped__ = f``). A | ||
| :exc:`ValueError` is now raised on cycle detection, matching the behavior of | ||
| :func:`inspect.unwrap`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this construction? Please don't use an LLM to generate this. Just use
lazy import inspectand check if there is nothing wrong with that construction as per the DPO thread.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For annotationlib, we'll clean it up either in a follow-up if codeowners do want it, or we will keep it as is until we need to modify annotationlib calls somewhere.