Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: miyadav The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughAdds repository secret-scanning: a GitHub Actions workflow to run Gitleaks on PRs and pushes to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
.github/workflows/secret-scan.yml (1)
26-26: Consider pinning GitHub Actions to specific commit SHAs.The workflow pins actions to major versions (
@v4,@v2,@v3) rather than specific commit SHAs. For security-critical workflows like secret scanning, pinning to immutable commit SHAs prevents potential supply chain attacks if action repositories are compromised.🔒 Proposed fix to pin actions to commit SHAs
Example approach (you'll need to look up current commit SHAs):
- name: Checkout code - uses: actions/checkout@v4 + uses: actions/checkout@<SHA> # v4.x.x with: fetch-depth: 0 - name: Run Gitleaks - uses: gitleaks/gitleaks-action@v2 + uses: gitleaks/gitleaks-action@<SHA> # v2.x.x env: - name: Upload SARIF report if: failure() - uses: github/codeql-action/upload-sarif@v3 + uses: github/codeql-action/upload-sarif@<SHA> # v3.x.xYou can find the current commit SHAs for these actions at:
Also applies to: 31-31, 39-39
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/secret-scan.yml at line 26, The workflow pins actions to mutable tags (e.g., the uses entries like "actions/checkout@v4", the gitleaks and codeql action uses) which risks supply-chain changes; update each "uses:" line in the secret-scan.yml that references actions/checkout, gitleaks (gitleaks-action), and github/codeql-action to use the corresponding immutable commit SHA (replace `@vX` with @<full-commit-sha>) for every occurrence (lines where "uses:" appears for these actions) and verify the SHAs by fetching the current tags/commits from the action repos before committing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/SECRET_SCANNING.md:
- Line 10: Update the inaccurate speed claim in the SECRET_SCANNING.md entry
that currently reads "**Speed:** ~4 seconds for full repository scan": either
change it to a realistic statement such as "**Speed:** typically completes in a
few minutes (observed ~2m11s for a 3.5GB repo)" or remove the specific numeric
duration and replace with "fast" / "typically completes in a few minutes"; edit
the exact string in the file so the README no longer claims "~4 seconds".
- Line 19: Update the phrase "High entropy strings" to the hyphenated compound
modifier "High-entropy strings" in the markdown content (the heading/line
currently reading "High entropy strings") so it reads "High-entropy strings"
wherever it's used as a modifier before a noun; locate the exact phrase in the
SECRET_SCANNING.md content and replace it with the hyphenated version to satisfy
grammar/static analysis rules.
In @.gitleaks.toml:
- Around line 39-41: The current gitleaks exclusion pattern '''\.md$''' is too
broad; update .gitleaks.toml to narrow or remove this rule by either deleting
the '''\.md$''' entry, replacing it with a whitelist of safe markdown filenames
(e.g., README.md|CHANGELOG.md) in the pattern, or keeping the exclusion but
adding a note in SECRET_SCANNING.md documenting the risk of secrets in markdown
and instructing developers to avoid pasting secrets into .md files; target the
pattern string '''\.md$''' when making the change.
---
Nitpick comments:
In @.github/workflows/secret-scan.yml:
- Line 26: The workflow pins actions to mutable tags (e.g., the uses entries
like "actions/checkout@v4", the gitleaks and codeql action uses) which risks
supply-chain changes; update each "uses:" line in the secret-scan.yml that
references actions/checkout, gitleaks (gitleaks-action), and
github/codeql-action to use the corresponding immutable commit SHA (replace `@vX`
with @<full-commit-sha>) for every occurrence (lines where "uses:" appears for
these actions) and verify the SHAs by fetching the current tags/commits from the
action repos before committing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0bbfdd85-f3e2-4eac-945b-6c1a28daa529
📒 Files selected for processing (3)
.github/SECRET_SCANNING.md.github/workflows/secret-scan.yml.gitleaks.toml
| - Database credentials and connection strings | ||
| - OAuth and JWT tokens | ||
| - Generic secrets (password=, api_key=, etc.) | ||
| - High entropy strings (randomized secrets) |
There was a problem hiding this comment.
Minor grammar: Use hyphenated compound modifier.
"High entropy strings" should be hyphenated as "high-entropy strings" when used as a compound modifier before a noun. As per static analysis tools.
📝 Suggested fix
- Generic secrets (password=, api_key=, etc.)
-- High entropy strings (randomized secrets)
+- High-entropy strings (randomized secrets)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - High entropy strings (randomized secrets) | |
| - High-entropy strings (randomized secrets) |
🧰 Tools
🪛 LanguageTool
[grammar] ~19-~19: Use a hyphen to join words.
Context: ...crets (password=, api_key=, etc.) - High entropy strings (randomized secrets) ##...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/SECRET_SCANNING.md at line 19, Update the phrase "High entropy
strings" to the hyphenated compound modifier "High-entropy strings" in the
markdown content (the heading/line currently reading "High entropy strings") so
it reads "High-entropy strings" wherever it's used as a modifier before a noun;
locate the exact phrase in the SECRET_SCANNING.md content and replace it with
the hyphenated version to satisfy grammar/static analysis rules.
| # Documentation | ||
| '''\.md$''', | ||
| ] |
There was a problem hiding this comment.
Consider narrowing the markdown exclusion.
Excluding all .md files from secret scanning may be too broad. While most documentation is safe, developers might accidentally paste real secrets into markdown files (e.g., in README examples, troubleshooting guides, or inline code blocks). Consider either:
- Removing this exclusion entirely and relying on stopwords/regex allowlist
- Only excluding specific safe markdown files like
README.mdorCHANGELOG.md - Keeping it but clearly documenting this risk in the SECRET_SCANNING.md guide
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.gitleaks.toml around lines 39 - 41, The current gitleaks exclusion pattern
'''\.md$''' is too broad; update .gitleaks.toml to narrow or remove this rule by
either deleting the '''\.md$''' entry, replacing it with a whitelist of safe
markdown filenames (e.g., README.md|CHANGELOG.md) in the pattern, or keeping the
exclusion but adding a note in SECRET_SCANNING.md documenting the risk of
secrets in markdown and instructing developers to avoid pasting secrets into .md
files; target the pattern string '''\.md$''' when making the change.
|
Scheduling required tests: |
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (1)
.github/SECRET_SCANNING.md (1)
19-19:⚠️ Potential issue | 🟡 MinorUse hyphenated compound modifier.
Line 19 should read “High-entropy strings” for correct compound-modifier grammar.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/SECRET_SCANNING.md at line 19, Replace the phrase "High entropy strings" with the hyphenated compound modifier "High-entropy strings" in the .github/SECRET_SCANNING.md content (locate the line containing the exact phrase "High entropy strings") to correct the grammar.
🧹 Nitpick comments (1)
.github/SECRET_SCANNING.md (1)
107-109: Mark exclusions list as non-exhaustive to prevent doc drift.This list is a subset of
.gitleaks.tomlexclusions (e.g., lockfiles,testdata/,*_test.go,bindata.goare also excluded). Consider labeling it as examples or expanding it.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/SECRET_SCANNING.md around lines 107 - 109, Update the "**Excluded paths:**", "**Excluded patterns:**" and "**Rules:**" lines so the exclusions list is explicitly non‑exhaustive—e.g., prepend a short note like "Examples only; not exhaustive" or "Subset of .gitleaks.toml exclusions" next to those headings and/or change the section title to "Examples of exclusions" to avoid doc drift; reference the existing headings "**Excluded paths:**", "**Excluded patterns:**", and "**Rules:**" when making this small wording change so readers know this is only a subset of the full .gitleaks.toml exclusions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/SECRET_SCANNING.md:
- Line 11: The statement "**Action: Blocks PR merge if secrets are detected**"
overstates behavior; update that sentence to clarify it reflects CI/checks
behavior rather than an absolute guarantee—replace the line text with something
like "**Action:** CI check fails (may block PR merge depending on branch
protection and required checks)" so it accurately notes that merge blocking
depends on repository branch protection and required CI checks; edit the exact
string shown on the existing line to the clarified wording.
- Line 8: The README line "**Runs on:** All pull requests and pushes to `main`
and `release-*` branches" is out of sync with the secret scan workflow; update
the text in SECRET_SCANNING.md to match the actual trigger in secret-scan.yml
(e.g., change to "pushes to `main` only" or explicitly list the triggers used),
or alternatively modify secret-scan.yml to include `push` on `release-*` and
`pull_request` if you want the doc to remain as-is; edit the specific line
containing that sentence in SECRET_SCANNING.md (or the `on:` block in
secret-scan.yml) so both sources state the same trigger scope.
- Line 9: The current sentence "**What it scans:** Only new commits in your PR"
is inaccurate given the workflow uses fetch-depth: 0 with gitleaks-action@v2
which causes a full git-history scan; update the doc to state that
gitleaks-action@v2 with fetch-depth: 0 scans the full repository history by
default, or change the workflow to scan only PR commits by adding the
GITLEAKS_ARGS environment variable with --log-opts="main..HEAD" to the
gitleaks-action@v2 step; reference gitleaks-action@v2, fetch-depth: 0,
GITLEAKS_ARGS and --log-opts="main..HEAD" when making the change.
---
Duplicate comments:
In @.github/SECRET_SCANNING.md:
- Line 19: Replace the phrase "High entropy strings" with the hyphenated
compound modifier "High-entropy strings" in the .github/SECRET_SCANNING.md
content (locate the line containing the exact phrase "High entropy strings") to
correct the grammar.
---
Nitpick comments:
In @.github/SECRET_SCANNING.md:
- Around line 107-109: Update the "**Excluded paths:**", "**Excluded
patterns:**" and "**Rules:**" lines so the exclusions list is explicitly
non‑exhaustive—e.g., prepend a short note like "Examples only; not exhaustive"
or "Subset of .gitleaks.toml exclusions" next to those headings and/or change
the section title to "Examples of exclusions" to avoid doc drift; reference the
existing headings "**Excluded paths:**", "**Excluded patterns:**", and
"**Rules:**" when making this small wording change so readers know this is only
a subset of the full .gitleaks.toml exclusions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3754582e-7e01-4226-9827-9e4b551988a9
📒 Files selected for processing (3)
.github/SECRET_SCANNING.md.github/workflows/secret-scan.yml.gitleaks.toml
✅ Files skipped from review due to trivial changes (2)
- .gitleaks.toml
- .github/workflows/secret-scan.yml
| ## How It Works | ||
|
|
||
| ### Automated CI Scanning | ||
| - **Runs on:** All pull requests and pushes to `main` and `release-*` branches |
There was a problem hiding this comment.
Fix trigger scope statement to match workflow config.
Line 8 says pushes to main and release-*, but .github/workflows/secret-scan.yml currently triggers push only on main. Please align the doc (or workflow) to avoid misleading contributors.
Proposed doc fix
-- **Runs on:** All pull requests and pushes to `main` and `release-*` branches
+- **Runs on:** Pull requests targeting `main` and `release-*`, and pushes to `main`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - **Runs on:** All pull requests and pushes to `main` and `release-*` branches | |
| - **Runs on:** Pull requests targeting `main` and `release-*`, and pushes to `main` |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/SECRET_SCANNING.md at line 8, The README line "**Runs on:** All pull
requests and pushes to `main` and `release-*` branches" is out of sync with the
secret scan workflow; update the text in SECRET_SCANNING.md to match the actual
trigger in secret-scan.yml (e.g., change to "pushes to `main` only" or
explicitly list the triggers used), or alternatively modify secret-scan.yml to
include `push` on `release-*` and `pull_request` if you want the doc to remain
as-is; edit the specific line containing that sentence in SECRET_SCANNING.md (or
the `on:` block in secret-scan.yml) so both sources state the same trigger
scope.
| - **Runs on:** All pull requests and pushes to `main` and `release-*` branches | ||
| - **What it scans:** Only new commits in your PR (not the entire git history) | ||
| - **Speed:** ~4 mins for full repository scan | ||
| - **Action:** Blocks PR merge if secrets are detected |
There was a problem hiding this comment.
Avoid overstating merge-blocking behavior.
Line 11 implies guaranteed merge blocking, but that depends on branch protection/required checks outside this file. Safer wording is that CI fails when findings are detected.
Proposed doc fix
-- **Action:** Blocks PR merge if secrets are detected
+- **Action:** Fails the secret-scan CI check if secrets are detected🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/SECRET_SCANNING.md at line 11, The statement "**Action: Blocks PR
merge if secrets are detected**" overstates behavior; update that sentence to
clarify it reflects CI/checks behavior rather than an absolute guarantee—replace
the line text with something like "**Action:** CI check fails (may block PR
merge depending on branch protection and required checks)" so it accurately
notes that merge blocking depends on repository branch protection and required
CI checks; edit the exact string shown on the existing line to the clarified
wording.
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (3)
.github/SECRET_SCANNING.md (3)
19-19:⚠️ Potential issue | 🟡 MinorHyphenate compound modifier.
Line 19 should be “High-entropy strings.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/SECRET_SCANNING.md at line 19, Update the phrase "High entropy strings (randomized secrets)" to use a hyphenated compound modifier: change it to "High-entropy strings (randomized secrets)" so the compound adjective before the noun is correctly hyphenated.
8-8:⚠️ Potential issue | 🟡 MinorTrigger scope is still inaccurate.
Line 8 says pushes run on
mainandrelease-*, but workflow config shows push runs onmainonly. Please align the sentence with.github/workflows/secret-scan.yml.Suggested doc edit
-- **Runs on:** All pull requests and pushes to `main` and `release-*` branches +- **Runs on:** Pull requests targeting `main` and `release-*`, and pushes to `main`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/SECRET_SCANNING.md at line 8, Update the sentence "**Runs on:** All pull requests and pushes to `main` and `release-*` branches" in SECRET_SCANNING.md to match the actual workflow trigger by removing `release-*` so it reads "**Runs on:** All pull requests and pushes to `main`" (ensure the wording exactly aligns with the triggers defined in secret-scan.yml).
11-11:⚠️ Potential issue | 🟡 MinorAvoid absolute “blocks merge” wording.
Line 11 should describe CI check failure; whether merge is blocked depends on branch protection settings.
Suggested doc edit
-- **Action:** Blocks PR merge if secrets are detected +- **Action:** Fails the secret-scan CI check (may block merge depending on branch protection)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/SECRET_SCANNING.md at line 11, Change the phrasing on the line currently reading "**Action:** Blocks PR merge if secrets are detected" to indicate the CI check fails rather than asserting merges are blocked unconditionally; update the text to something like "**Action:** Fails CI check if secrets are detected (merge behavior depends on branch protection settings)" so the doc reflects that actual merge blocking depends on repository branch protection rules and not the scanner itself.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/SECRET_SCANNING.md:
- Line 10: The "Speed: ~4 mins for full repository scan" line conflicts with the
preceding "PR-commit scanning" scope; update the sentence that currently reads
"Speed: ~4 mins for full repository scan" so it either (a) specifies the time
for PR-commit scans (e.g., "Speed: ~4 mins per PR-commit scan") to match the
described mode, or (b) clearly documents both modes (e.g., "Speed: ~4 mins per
PR-commit scan; full repository scans may take longer") thereby removing scope
confusion—locate and edit the exact phrase "Speed: ~4 mins for full repository
scan" to one of these clarified variants.
- Line 9: The Gitleaks scan range is hardcoded to use GITLEAKS_ARGS:
--log-opts="main..HEAD", which mis-scans PRs targeting release-* branches;
update the workflow to use the repository base ref variable by replacing the
fixed "main..HEAD" with a base-ref-aware range such as
"${GITHUB_BASE_REF}..HEAD" (or add conditional logic to fall back to main when
GITHUB_BASE_REF is empty), and update the GITLEAKS_ARGS reference and any
documentation in SECRET_SCANNING.md to reflect this change so scans truly cover
only the PR commits.
---
Duplicate comments:
In @.github/SECRET_SCANNING.md:
- Line 19: Update the phrase "High entropy strings (randomized secrets)" to use
a hyphenated compound modifier: change it to "High-entropy strings (randomized
secrets)" so the compound adjective before the noun is correctly hyphenated.
- Line 8: Update the sentence "**Runs on:** All pull requests and pushes to
`main` and `release-*` branches" in SECRET_SCANNING.md to match the actual
workflow trigger by removing `release-*` so it reads "**Runs on:** All pull
requests and pushes to `main`" (ensure the wording exactly aligns with the
triggers defined in secret-scan.yml).
- Line 11: Change the phrasing on the line currently reading "**Action:** Blocks
PR merge if secrets are detected" to indicate the CI check fails rather than
asserting merges are blocked unconditionally; update the text to something like
"**Action:** Fails CI check if secrets are detected (merge behavior depends on
branch protection settings)" so the doc reflects that actual merge blocking
depends on repository branch protection rules and not the scanner itself.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 676ab0ec-0a05-4712-9114-844473ada441
📒 Files selected for processing (2)
.github/SECRET_SCANNING.md.github/workflows/secret-scan.yml
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/secret-scan.yml
|
|
||
| ### Automated CI Scanning | ||
| - **Runs on:** All pull requests and pushes to `main` and `release-*` branches | ||
| - **What it scans:** Only new commits in your PR via `gitleaks-action@v2` with `GITLEAKS_ARGS: --log-opts="main..HEAD"` (not the entire git history despite `fetch-depth: 0`) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify trigger targets and gitleaks range args from workflow.
# Expected: pull_request includes main/release-*; gitleaks arg is hardcoded main..HEAD.
set -euo pipefail
echo "== Workflow trigger block =="
sed -n '1,40p' .github/workflows/secret-scan.yml
echo
echo "== Gitleaks step and args =="
rg -n -C3 'gitleaks-action@v2|GITLEAKS_ARGS|log-opts' .github/workflows/secret-scan.ymlRepository: openshift/origin
Length of output: 1711
🏁 Script executed:
cat -n .github/SECRET_SCANNING.md | head -20Repository: openshift/origin
Length of output: 1069
🏁 Script executed:
# Check for any conditional logic in the workflow that might adjust gitleaks args based on target branch
rg -n 'if:|env\.|GITLEAKS_ARGS' .github/workflows/secret-scan.ymlRepository: openshift/origin
Length of output: 178
Gitleaks scan range is hardcoded to main..HEAD, which fails for release-* PRs.
Line 9 claims "Only new commits in your PR," but GITLEAKS_ARGS: --log-opts="main..HEAD" is hardcoded with no branch-awareness. For PRs targeting release-*, this scans commits from main that aren't in the target branch—not just PR commits. Either document this limitation or switch to ${GITHUB_BASE_REF}..HEAD for base-ref-aware scanning.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/SECRET_SCANNING.md at line 9, The Gitleaks scan range is hardcoded
to use GITLEAKS_ARGS: --log-opts="main..HEAD", which mis-scans PRs targeting
release-* branches; update the workflow to use the repository base ref variable
by replacing the fixed "main..HEAD" with a base-ref-aware range such as
"${GITHUB_BASE_REF}..HEAD" (or add conditional logic to fall back to main when
GITHUB_BASE_REF is empty), and update the GITLEAKS_ARGS reference and any
documentation in SECRET_SCANNING.md to reflect this change so scans truly cover
only the PR commits.
| ### Automated CI Scanning | ||
| - **Runs on:** All pull requests and pushes to `main` and `release-*` branches | ||
| - **What it scans:** Only new commits in your PR via `gitleaks-action@v2` with `GITLEAKS_ARGS: --log-opts="main..HEAD"` (not the entire git history despite `fetch-depth: 0`) | ||
| - **Speed:** ~4 mins for full repository scan |
There was a problem hiding this comment.
Speed line conflicts with stated scan mode.
Line 10 references “full repository scan,” but Line 9 describes PR-commit scanning. Reword this to avoid mixing two different scan scopes.
Suggested doc edit
-- **Speed:** ~4 mins for full repository scan
+- **Speed:** Typically completes in a few minutes (depends on commit range and repository size)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - **Speed:** ~4 mins for full repository scan | |
| - **Speed:** Typically completes in a few minutes (depends on commit range and repository size) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/SECRET_SCANNING.md at line 10, The "Speed: ~4 mins for full
repository scan" line conflicts with the preceding "PR-commit scanning" scope;
update the sentence that currently reads "Speed: ~4 mins for full repository
scan" so it either (a) specifies the time for PR-commit scans (e.g., "Speed: ~4
mins per PR-commit scan") to match the described mode, or (b) clearly documents
both modes (e.g., "Speed: ~4 mins per PR-commit scan; full repository scans may
take longer") thereby removing scope confusion—locate and edit the exact phrase
"Speed: ~4 mins for full repository scan" to one of these clarified variants.
|
Scheduling required tests: |
|
@miyadav: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PTAL when time permits , if this is needed .
All the warning were really old and are not relevant , but it might be a good way to protect any future misses.
Validated by making pr to my master fork
Assisted-by: claudecode