Skip to content

fix(ui): fix few common ui bugs#8425

Merged
Subash-Mohan merged 4 commits intomainfrom
fix-action-block-issue-1
Feb 16, 2026
Merged

fix(ui): fix few common ui bugs#8425
Subash-Mohan merged 4 commits intomainfrom
fix-action-block-issue-1

Conversation

@Subash-Mohan
Copy link
Copy Markdown
Contributor

@Subash-Mohan Subash-Mohan commented Feb 13, 2026

Description

  • Fixed expandable text streaming display by replacing scroll-based approach with CSS transform snapping to element
    boundaries, preventing partial block clipping and scroll jitter
  • Fixed button height inconsistencies in parallel/streaming timeline headers by adding proper size props
  • Fixed SearchChipList unnecessary re-renders by replacing useState/useEffect state management with useMemo derivation and
    simple visibleCount state
  • Fixed tab trigger text spacing and source tag description card padding

How Has This Been Tested?

Tested all he above scenarios

Additional Options

  • [Required] I have considered whether this PR needs to be cherry-picked to the latest beta branch.
  • [Optional] Override Linear Check

Summary by cubic

Fixes streaming text cutoff and jitter by snapping content to block boundaries with CSS transforms, and aligns button sizing and spacing for cleaner timelines. Also reduces SearchChipList re-renders to improve timeline performance.

  • Bug Fixes
    • Streaming text: replaced scroll-to-bottom with transform-based snap to block boundaries to prevent clipping and flicker; accurate truncation detection for streaming/static content with a top ellipsis.
    • Timeline headers: standardized expand/collapse button size (sm) and transparent background to fix height mismatches.
    • SearchChipList: derive display via useMemo with a simple visibleCount; removed batch state and useEffects; stabilized a single “more” key to avoid re-renders.
    • UI spacing: added small padding for tab trigger text and SourceTagDetailsCard descriptions for consistent layout.

Written for commit c3e69db. Summary will update on new commits.

@Subash-Mohan Subash-Mohan requested a review from a team as a code owner February 13, 2026 11:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2026

Preview Deployment

Status Preview Commit Updated
https://onyx-preview-pee8ybhaq-danswer.vercel.app c3e69db 2026-02-16 11:06:05 UTC

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

Fixed multiple UI consistency issues across timeline headers, expandable text display, and source tags:

  • Replaced scroll-based truncation with CSS transform snapping in ExpandableTextDisplay to prevent partial block clipping during streaming
  • Optimized SearchChipList by replacing useState/useEffect with useMemo derivation to eliminate unnecessary re-renders
  • Added explicit size props to buttons in timeline headers for consistent heights
  • Improved spacing and padding in tab triggers and source tag description cards

All changes are focused styling and performance improvements with no breaking changes or logic modifications.

Confidence Score: 4/5

  • This PR is safe to merge with minor cleanup opportunity
  • All changes are UI/styling improvements and performance optimizations. The ExpandableTextDisplay refactor is complex but well-structured. One minor cleanup suggestion for unused batchId field in SearchChipList.
  • No files require special attention - all changes are straightforward UI improvements

Important Files Changed

Filename Overview
web/src/app/app/message/messageComponents/timeline/headers/ParallelStreamingHeader.tsx Added size="sm" prop and className="bg-transparent" to button for consistent styling
web/src/app/app/message/messageComponents/timeline/headers/StreamingHeader.tsx Added size="md" prop to OpalButton for consistent height across header buttons
web/src/app/app/message/messageComponents/timeline/renderers/search/SearchChipList.tsx Replaced useState/useEffect with useMemo for display list derivation, eliminating unnecessary re-renders. Minor cleanup opportunity for unused batchId field.
web/src/refresh-components/Tabs.tsx Added px-0.5 wrapper div around text children for improved spacing consistency
web/src/refresh-components/buttons/source-tag/SourceTagDetailsCard.tsx Wrapped description in div with px-1.5 pb-1 for consistent padding with rest of card
web/src/refresh-components/texts/ExpandableTextDisplay.tsx Replaced scroll-based streaming display with CSS transform snapping to element boundaries, preventing partial block clipping. Complex but well-structured change that adds CONTAINER_TAGS set and snap algorithm logic.

Last reviewed commit: 824caab

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

if (items.length > initialCount) {
initial.push({ type: "more", batchId: 0 });
if (effectiveCount < items.length) {
chips.push({ type: "more", batchId: 0 });
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batchId field is no longer used and can be removed from the type

Suggested change
chips.push({ type: "more", batchId: 0 });
chips.push({ type: "more" });

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2026

🖼️ Visual Regression Report

Project Changed Added Removed Unchanged Report
admin 12 0 0 36 View Report
exclusive 0 0 0 0 No screenshots

@Subash-Mohan Subash-Mohan changed the title Fix action block issue 1 fix(ui): fix few common ui bugs Feb 13, 2026
Copy link
Copy Markdown
Contributor

@raunakab raunakab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! Just a few small comments here.

collapsible ? (
<Button
prominence="tertiary"
size="sm"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this one is supposed to be "md"?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for now, but I will be throwing in some important LineItemLayout fixes which this component should use.

@Subash-Mohan Subash-Mohan force-pushed the fix-action-block-issue-1 branch from 824caab to c3e69db Compare February 16, 2026 11:02
@Subash-Mohan Subash-Mohan added this pull request to the merge queue Feb 16, 2026
Merged via the queue into main with commit ddb14ec Feb 16, 2026
88 checks passed
@Subash-Mohan Subash-Mohan deleted the fix-action-block-issue-1 branch February 16, 2026 11:29
Subash-Mohan added a commit that referenced this pull request Feb 20, 2026
Subash-Mohan added a commit that referenced this pull request Feb 20, 2026
Danelegend pushed a commit that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants