Skip to content

chore(playwright): remove chromatic#8339

Merged
jmelahman merged 2 commits intomainfrom
jamison/just-rm-chromatic
Feb 11, 2026
Merged

chore(playwright): remove chromatic#8339
jmelahman merged 2 commits intomainfrom
jamison/just-rm-chromatic

Conversation

@jmelahman
Copy link
Copy Markdown
Contributor

@jmelahman jmelahman commented Feb 11, 2026

Description

We currently don't use chromatic, so remove it. I intend to replace it in #8311 and want to keep that diff focused on the new screenshot workflow.

How Has This Been Tested?

Captured by existing

Additional Options

  • [Required] I have considered whether this PR needs to be cherry-picked to the latest beta branch.
  • [Optional] Override Linear Check

Summary by cubic

Removed Chromatic from the web app and CI, and switched all E2E tests to native Playwright. This simplifies our test setup and removes unused visual diff tooling.

  • Refactors
    • Removed Chromatic deps and version-comment; cleaned the lockfile.
    • Deleted Chromatic job from pr-playwright-tests.yml.
    • Updated all E2E imports from @chromatic-com/playwright to @playwright/test.
    • Removed admin_pages.spec.ts and chromaticSnapshots.json.
    • Cleaned docs/config: removed README upload step and set Playwright reporter to list.

Written for commit 87f887e. Summary will update on new commits.

@jmelahman jmelahman requested a review from a team as a code owner February 11, 2026 18:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 11, 2026

Preview Deployment

Status Preview Commit Updated
https://onyx-preview-f3w4iuw72-danswer.vercel.app 87f887e 2026-02-11 18:33:34 UTC

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 11, 2026

Greptile Overview

Greptile Summary

Removes all Chromatic visual regression testing infrastructure that's no longer in use. The changes include removing the @chromatic-com/playwright and chromatic npm packages, deleting the Chromatic-specific test file (admin_pages.spec.ts) and snapshots configuration (chromaticSnapshots.json), updating all test imports to use standard @playwright/test, and removing documentation and CI workflow references.

  • Removed 2 npm dependencies: @chromatic-com/playwright and chromatic
  • Deleted Chromatic-specific test file and snapshot configuration
  • Updated 20 test files to import from @playwright/test instead of @chromatic-com/playwright
  • Removed commented-out CI job definition for Chromatic
  • Cleaned up documentation referencing Chromatic usage

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • This is a straightforward dependency removal that properly cleans up all references to Chromatic. The changes are mechanical (import statement updates), well-scoped, and remove unused code. All test files were updated consistently to use the standard Playwright import, and the dependency removal was properly reflected in both package.json and package-lock.json. The only minor issue is an outdated comment in playwright.config.ts.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/pr-playwright-tests.yml Removed commented-out Chromatic job definition - clean removal of unused CI step
web/README.md Removed Chromatic upload documentation - appropriate cleanup
web/package.json Removed Chromatic dependencies and version comment - clean dependency removal
web/tests/e2e/admin_pages.spec.ts Deleted Chromatic-specific test file that was using chromaticSnapshots.json
web/tests/e2e/chromaticSnapshots.json Deleted Chromatic snapshots configuration file

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 24 files

@jmelahman jmelahman enabled auto-merge February 11, 2026 18:49
@jmelahman jmelahman added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit 51de334 Feb 11, 2026
83 checks passed
@jmelahman jmelahman deleted the jamison/just-rm-chromatic branch February 11, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants