Skip to content

chore(deployment): only try to build desktop if semver-like tag#8316

Merged
jmelahman merged 1 commit intomainfrom
jamison/skip-desktop-semver
Feb 11, 2026
Merged

chore(deployment): only try to build desktop if semver-like tag#8316
jmelahman merged 1 commit intomainfrom
jamison/skip-desktop-semver

Conversation

@jmelahman
Copy link
Copy Markdown
Contributor

@jmelahman jmelahman commented Feb 11, 2026

Description

The desktop builds require semver tags (a detail required by Tauri, not us), so let's not even try to build for non-semver tags since we know it's going to fail (and cause a second ping in #monitor-deployments).

How Has This Been Tested?

Nah

Additional Options

  • [Required] I have considered whether this PR needs to be cherry-picked to the latest beta branch.
  • [Optional] Override Linear Check

Summary by cubic

Update deployment workflow to only build desktop when the tag is semver-like and not a beta. This prevents Tauri build failures and reduces noisy retries in deployments.

Written for commit 8679423. Summary will update on new commits.

@jmelahman jmelahman requested a review from a team as a code owner February 11, 2026 00:48
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@jmelahman jmelahman enabled auto-merge February 11, 2026 00:56
@jmelahman jmelahman added this pull request to the merge queue Feb 11, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Feb 11, 2026

Greptile Overview

Greptile Summary

This PR updates the deployment workflow’s determine-builds gating so that build-desktop only runs for version-like tags (and not for beta tags), rather than running for all non-beta/non-nightly tags.

This fits into the existing workflow pattern where determine-builds computes build flags (web/cloud/backend/model/desktop) that subsequent jobs use via if: conditions. The change reduces known-failing desktop builds for non-version tags while leaving cloud and other build paths unchanged.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The change is a small, localized adjustment to a single bash conditional in the deployment workflow that only affects when the desktop build job is triggered; it does not alter build steps, credentials, or publishing logic.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/deployment.yml Gates desktop builds to run only on version-like tags (excluding beta) instead of on all non-beta/non-nightly tags; no merge-blocking issues found in the change.

Sequence Diagram

sequenceDiagram
  autonumber
  participant GH as GitHub (tag push)
  participant DB as determine-builds job
  participant Desk as build-desktop job
  participant Web as web/backend/model jobs

  GH->>DB: Trigger workflow on tag
  DB->>DB: Compute flags (IS_CLOUD/IS_VERSION_TAG/IS_BETA/...)
  alt Cloud tag
    DB->>Web: set build-web-cloud=true
  else Non-cloud tag
    DB->>Web: set build-web=true
    alt IS_VERSION_TAG == true and IS_BETA != true
      DB->>Desk: output build-desktop=true
      Desk-->>GH: Run desktop build matrix
    else Otherwise
      DB->>Desk: output build-desktop=false
      Desk-->>GH: Skipped
    end
  end
Loading

Merged via the queue into main with commit d0be7dd Feb 11, 2026
82 checks passed
@jmelahman jmelahman deleted the jamison/skip-desktop-semver branch February 11, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants