chore: bump sandbox cpu and memory limits#8208
Merged
wenxi-onyx merged 2 commits intomainfrom Feb 5, 2026
Merged
Conversation
Contributor
Greptile OverviewGreptile SummaryThis PR adjusts Kubernetes resource limits for the sandbox pod’s S3 sync sidecar container, increasing its CPU and memory limits. The change is localized to the pod spec construction in Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller as Build/Session Manager
participant KSM as KubernetesSandboxManager
participant K8s as Kubernetes API Server
Caller->>KSM: provision(user/session)
KSM->>K8s: Create Pod (sandbox + s3-sync sidecar)
Note over KSM,K8s: PR bumps sidecar limits to 8000m CPU / 8Gi RAM
K8s-->>KSM: Pod scheduled (or rejected by quota/LimitRange)
Caller->>KSM: exec incremental sync / workspace ops
KSM->>K8s: kubectl exec into sidecar/sandbox
K8s-->>KSM: command output
Caller-->>KSM: terminate()
KSM->>K8s: Delete Pod
|
backend/onyx/server/features/build/sandbox/kubernetes/kubernetes_sandbox_manager.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note: there is no quota constraint on limit vs request
sandbox-nodes-firewalled Nodegroup Resources
Total Nodegroup Capacity:
Per-Node Resources:
Changes: file-sync Sidecar Resource Limits
Updated the file-sync sidecar container to enable faster S3 downloads during pod initialization:
Previous:
New:
Rationale:
How Has This Been Tested?
Additional Options
Summary by cubic
Increase Kubernetes sandbox pod resource limits to reduce CPU throttling and OOMs during heavier workloads.
Limits raised from 1000m CPU to 4000m and from 4Gi memory to 6Gi; requests increased from 50m CPU/128Mi to 250m CPU/256Mi.
Written for commit 47b06df. Summary will update on new commits.