Skip to content

fix: attachment prompt tweak#7929

Merged
Weves merged 1 commit intomainfrom
prompt-tweak
Jan 28, 2026
Merged

fix: attachment prompt tweak#7929
Weves merged 1 commit intomainfrom
prompt-tweak

Conversation

@Weves
Copy link
Copy Markdown
Contributor

@Weves Weves commented Jan 28, 2026

Description

How Has This Been Tested?

Additional Options

  • [Required] I have considered whether this PR needs to be cherry-picked to the latest beta branch.
  • [Optional] Override Linear Check

Summary by cubic

Removed the "Attachments (PRIORITY)" section from AGENTS.template.md to align with current attachment handling and reduce redundant guidance. This avoids over-prioritizing uploaded files by default and keeps the template concise.

Written for commit 0baf6d9. Summary will update on new commits.

@Weves Weves requested a review from a team as a code owner January 28, 2026 06:44
@Weves Weves merged commit a79e581 into main Jan 28, 2026
17 of 19 checks passed
@Weves Weves deleted the prompt-tweak branch January 28, 2026 06:44
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Jan 28, 2026

Greptile Overview

Greptile Summary

This PR removes the "Attachments (PRIORITY)" section from the agent instructions template (AGENTS.template.md). The removed section contained 28 lines of guidance instructing AI agents to prioritize user-uploaded files in the attachments/ directory.

Changes:

  • Removed prescriptive instructions about checking, reading, and prioritizing attachment files
  • Eliminated the requirement for agents to check attachments/ at the start of every task
  • Streamlined the template by removing redundant guidance

Context:
The attachments/ directory infrastructure remains intact in the codebase - it's still created via setup_attachments_directory() in directory_manager.py:491-511 and is part of the session workspace structure. This change only removes the explicit prompting that told agents to treat attachments as high-priority context.

Impact:
This aligns with a more balanced approach to attachment handling, allowing the AI agent to determine relevance contextually rather than being instructed to always prioritize uploaded files. The functionality for file uploads remains unchanged.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a simple documentation/prompt removal that doesn't affect any code logic or functionality. The attachments/ directory infrastructure remains fully intact, and this only removes prescriptive instructions from the agent template.
  • No files require special attention

Important Files Changed

Filename Overview
backend/onyx/server/features/build/AGENTS.template.md Removed "Attachments (PRIORITY)" section to streamline agent instructions

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Template as AGENTS.template.md
    participant DirMgr as DirectoryManager
    participant Agent as AI Agent (Steve)
    participant Attach as attachments/

    Note over Dev,Template: PR #7929: Attachment Prompt Tweak
    
    Dev->>Template: Remove "Attachments (PRIORITY)" section
    Note over Template: 28 lines of prescriptive<br/>attachment guidance removed
    
    Note over DirMgr,Attach: Infrastructure unchanged
    
    DirMgr->>Attach: setup_attachments_directory()<br/>(still creates directory)
    Note over Attach: Directory structure<br/>remains intact
    
    Note over Agent: Before PR
    Template->>Agent: "MUST check attachments/"<br/>"These files are critically important"<br/>"Check at start of every task"
    
    Note over Agent: After PR
    Template->>Agent: (No prescriptive attachment guidance)
    Note over Agent: Agent determines<br/>relevance contextually
    
    Note over Dev,Attach: Result: More balanced approach,<br/>no code changes, only prompt changes
Loading

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant