fix(playwright): waitFor instead of waitForSelector for action popover button#7464
Merged
fix(playwright): waitFor instead of waitForSelector for action popover button#7464
Conversation
Contributor
Greptile SummaryRemoved the
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as E2E Test
participant sendMessage as sendMessage()
participant Page as Browser Page
participant UI as Chat UI
Test->>sendMessage: Call with message text
sendMessage->>Page: Count existing AI messages
Page-->>sendMessage: existingMessageCount
sendMessage->>Page: Click chat input textarea
sendMessage->>Page: Fill message text
sendMessage->>Page: Click send button
sendMessage->>Page: Wait for AI message count to increase
Note over sendMessage,Page: Timeout: 30 seconds
Page->>UI: Monitor for new AI message
UI-->>Page: New AI message appears
Page-->>sendMessage: Count increased
sendMessage->>Page: Wait for URL to contain 'chatId='
Note over sendMessage,Page: Timeout: 10 seconds
Page-->>sendMessage: URL updated
Note over sendMessage: REMOVED: waitForLoadState("networkidle")
sendMessage-->>Test: Message sent successfully
|
jmelahman
approved these changes
Jan 16, 2026
rohoswagger
pushed a commit
that referenced
this pull request
Jan 19, 2026
jessicasingh7
pushed a commit
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For action popover, use
locator.waitForinstead ofpage.waitForSelectorthe latter is deprecated. we should make this switch across the playwright suite generally. my theory is the test runner is stalling and that issue is exacerbated by waitForSelector.
How Has This Been Tested?
existing
Additional Options
Summary by cubic
Removed networkidle wait in sendMessage and a redundant AI response check to reduce flakiness with streaming/background requests. Stabilized Action Management by waiting on locators before clicking, making tests faster and more reliable.
Written for commit c01f943. Summary will update on new commits.