fix(fe): avoid internal table scroll on query history page

[jmelahman]

Description

before

after

Additional Options

Closes https://linear.app/onyx-app/issue/ENG-3249/query-history-table-has-2-scroll-bars

---

Summary by cubic

Eliminated the extra internal scrollbar on the Query History page so the table scrolls with the page. Addresses Linear ENG-3249.

• Bug Fixes
  • Removed block-level Text (as="p") in table cells to prevent nested overflow.
  • Positioned the full-row Link overlay with top-0 to align correctly and avoid internal scroll.

^{Written for commit e243659. Summary will update on new commits.}

[cubic-dev-ai]

No issues found across 1 file

[greptile-apps]

Greptile Overview

Greptile Summary

This PR successfully fixes the double scrollbar issue on the Query History page (Linear ENG-3249). The fix involves two complementary changes:

1. Removed block-level Text components: Changed <Text as="p"> back to <Text> (which defaults to <span>) in table cells containing the first user message and first AI response. This prevents block-level elements from creating nested overflow contexts within table cells, which was the root cause of the internal scrollbar.

2. Fixed Link overlay positioning: Added top-0 to the absolutely positioned Link element that makes entire table rows clickable. This ensures the overlay is properly aligned from the top of the relative parent (TableRow), eliminating any positioning issues.

The changes are minimal, focused, and directly address the reported issue. The fix aligns with the recent codebase refactor (commit 700db01) that made Text default to span instead of requiring explicit as="p" declarations for block-level rendering.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are minimal, well-scoped, and directly fix a UI bug without introducing new functionality or modifying business logic. The fix correctly addresses the root cause (block-level elements in table cells causing overflow) with a clean solution (using inline Text components). No security, performance, or compatibility concerns identified.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
web/src/app/ee/admin/performance/query-history/QueryHistoryTable.tsx	5/5	Removed as="p" from Text components in table cells and added top-0 to absolute Link positioning. Changes correctly fix double scrollbar issue by preventing block-level overflow.

Sequence Diagram

sequenceDiagram
    participant User
    participant Browser
    participant QueryHistoryTable
    participant TableRow
    participant TableCell
    participant Text
    participant LinkOverlay as Link Overlay

    User->>Browser: Visit Query History Page
    Browser->>QueryHistoryTable: Render component
    QueryHistoryTable->>TableRow: Render with cursor-pointer and relative positioning
    TableRow->>TableCell: Render cells with chat data
    TableCell->>Text: Render as inline span element
    Note over Text: Prevents block-level overflow
    TableRow->>LinkOverlay: Render absolute positioned overlay with top-0
    Note over LinkOverlay: Enables full-row clickability
    User->>LinkOverlay: Click anywhere on row
    LinkOverlay->>Browser: Navigate to detail page

Loading