doc: fix the version tls.DEFAULT_CIPHERS was added#59247
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Aug 18, 2025
Merged
doc: fix the version tls.DEFAULT_CIPHERS was added#59247nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
42be7f6 (originally included in 19.8.0 and later backported to 18.16.0) added documentation on how to use
tls.DEFAULT_CIPHERS.However, that commit added the documentation with the version specified as
REAPLCEME, causing the published documentation to state thattls.DEFAULT_CIPHERSwas added in 19.8.0 and 18.16.0, which is incorrect - that commit states thattls.DEFAULT_CIPHERSalready existed, and the only thing it added was an explanation on how to use it.In fact, by examining the git log, it can be seen that
tls.DEFAULT_CIPHERSwas added by commitaf80e7b, which was included in 0.11.3.
Fixes: #59246