Skip to content

node-api: remove deprecated attribute from napi_module_register#56162

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
vmoroz:PR/undeprecate_napi_module_register
Dec 20, 2024
Merged

node-api: remove deprecated attribute from napi_module_register#56162
nodejs-github-bot merged 1 commit intonodejs:mainfrom
vmoroz:PR/undeprecate_napi_module_register

Conversation

@vmoroz
Copy link
Copy Markdown
Member

@vmoroz vmoroz commented Dec 7, 2024

This PR targets to addresses the issue #56153 by removing the [[deprecated]] attribute from the napi_module_register function.

The code described in the issue does not use the napi_module_register function as it was intended from a module shared library. Instead, it uses it to register modules for embedding scenarios. While it was never the intended use, we currently do not have a better approach to register modules before Environment is created until we complete the new embedding API - PR #54660.

We discussed the issue in the Node-API meeting on Dec 6th 2024, and decided that the quickest and the least intrusive way to address it is to remove the [[deprecated]] attribute from the napi_module_register function for now.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants