meta: allow users to reopen stale issues via commands#55498
Closed
avivkeller wants to merge 2 commits intonodejs:mainfrom
avivkeller:patch-634036
Closed
meta: allow users to reopen stale issues via commands#55498avivkeller wants to merge 2 commits intonodejs:mainfrom avivkeller:patch-634036
avivkeller wants to merge 2 commits intonodejs:mainfrom
avivkeller:patch-634036
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
Member
Author
|
BTW the cons of this is that it may slow down our actions by a few seconds, if a lot of users are commenting at the same time, and it'll clog the list of actions that ran at https://github.com/nodejs/node/actions Also see #54672 |
jasnell
approved these changes
Nov 5, 2024
avivkeller
added
the
author ready
aduh95
reviewed
Nov 5, 2024
bnb
approved these changes
Nov 7, 2024
Contributor
|
+1 but this might be something we want the @nodejs/tsc to review as it does fundamentally change how we manage issues. |
Member
Author
|
Also, once this lands, we should look into landing #54672, and similar PRs |
marco-ippolito
added
commit-queue
Member
Author
|
Hey @marco-ippolito! I see you started to, then stopped, this PR from the queue. Is there anything I can do to get this merged? Or is the project going in a different direction or something? Thanks! |
marco-ippolito
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/55498 ✔ Done loading data for nodejs/node/pull/55498 ----------------------------------- PR info ------------------------------------ Title meta: allow users to reopen stale issues via commands (#55498) Author Aviv Keller <me@aviv.sh> (@avivkeller) Branch avivkeller:patch-634036 -> nodejs:main Labels meta, author ready, commit-queue-squash Commits 2 - meta: allow users to reopen stale issues via commands - fixup! meta: allow users to reopen stale issues via commands Committers 2 - GitHub <noreply@github.com> - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/55498 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55498 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 23 Oct 2024 13:16:00 GMT ✔ Approvals: 3 ✔ - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/55498#pullrequestreview-2389096709 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/55498#pullrequestreview-2416971837 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/55498#pullrequestreview-2421545786 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14942808745 |
RafaelGSS
approved these changes
May 10, 2025
Member
Author
😕 |
Member
Author
|
Not sure what went wrong here? The GitHub CI seems green? |
Member
|
Maybe try to rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft as I'd love some opinions on whether this is behavior the project would like to support.
@ljharb pointed out in this thread that it would be ideal if we "can offer a stalebot command that anyone can use to reopen [the issue]".
This is a basic implemention of such commands, so I'd love some opinions on whether this behavior we'd want to support.
(@ljharb do you have anything to add?)