fs: introduce dirent.parentPath#50976
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Dec 2, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to replace
dirent.pathusing a name that's less likely to create confusion. The value ofdirent.pathused to be "the path to the file corresponding to theDirent", and is not "the path to the parent directory". IMO the name doesn't reflect that, usingdirnamewould be a better fit.If this PR is accepted, I'll close #50838 and open another PR to deprecate
dirent.path.