esm: remove specifier resolution flag#44859
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 4, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
--experimental-specifier-resolutionflag. The loaders team has been planning on removing this as soon as it became possible to replicate the behavior via a custom loader, and today it is: https://github.com/nodejs/loaders-test/tree/main/commonjs-extension-resolution-loader. That loader passes the same tests as the flag’s tests from the Node codebase. This PR both removes the flag and adds a reference to that loader to the docs.