Skip to content

fs: add recursive cp method#39372

Closed
bcoe wants to merge 1 commit intonodejs:masterfrom
bcoe:copy
Closed

fs: add recursive cp method#39372
bcoe wants to merge 1 commit intonodejs:masterfrom
bcoe:copy

Conversation

@bcoe
Copy link
Copy Markdown
Contributor

@bcoe bcoe commented Jul 13, 2021 •
edited by aduh95
Loading

Introduces recursive cp method, based on fs-extra implementation

Refs: nodejs/tooling#98
Fixes: #35880

Opening to start conversation.

TODO:

  • still have many tests to write, to increase coverage. (coverage is at 92%).
  • need to document sync and promise API.

CC: @nodejs/tooling, @jprichardson, @manidlou, @RyanZim

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

+6 more reviewers

@merceyz merceyz merceyz left review comments

@manidlou manidlou manidlou left review comments

@RyanZim RyanZim RyanZim left review comments

@Mesteery Mesteery Mesteery left review comments

@joesepi joesepi joesepi approved these changes

@iansu iansu iansu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. experimental Issues and PRs related to experimental features. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs: add cp method