src: combine internal file read utils

[devsnek]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[bnoordhuis]

LGTM but can you drop the braces around the single-statement if statements?

[devsnek]

@bnoordhuis i'd rather not do braceless if it isn't too much of a problem.

[bnoordhuis]

It's at odds with the house style. Let me turn it around: what's the problem with braceless style?

[devsnek]

@bnoordhuis i don't think we really have a style one way or the other (if we wanted to, we should add a lint). The problem i have with braceless is that if braces eventually need to be added for multiple statements it shows an extra two lines of change in the diff.

[bnoordhuis]

Majority rule. I did a quick scan - <insert not exact science warning> - and the braceless variant makes up 60% of the single-line if statements:

# braces
$ find src -name \*.cc | xargs cat | perl -e 'while(<>){s/\s+//g;$i=$.+2 if/^if\(.+\{/;$n++ if/^\}/&&$.==$i}print"$n\n"'
582

# braceless
$ find src -name \*.cc | xargs cat | grep -E 'if \(.+\)' | grep -v '{' | grep -c .
1419

The if statements with braces usually have multi-line else clauses.

[devsnek]

is there some specific problem you have with braces? It seems they're prevalent in our source, and we don't have a lint against them, so I'm not sure why I wouldn't be able to use them.

[bnoordhuis]

The prevailing style is to omit braces, ergo, new code should omit braces. Consistency trumps personal preference.

[jasnell]

Ping @devsnek .. needs to be rebased

[github-actions]

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.