Skip to content

test: add missing test flags#30971

Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig:test-fix
Closed

test: add missing test flags#30971
cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig:test-fix

Conversation

@cjihrig
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig commented Dec 15, 2019

test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants