src: expose ability to set options#30466
Closed
codebytere wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the ability to pass cli flags through an API for the embedder use case.
Electron needs to do its own parsing of arguments, and before this was unable to handle Node.js' cli flags at all, which prevented consumers from doing useful things like enabling experimental Node.js features.
cc @addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes