src: add NODE_EXTERN to class definition#22559
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: add NODE_EXTERN to class definition#22559addaleax wants to merge 1 commit intonodejs:masterfrom
NODE_EXTERN to class definition#22559addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be part of public class definitions for Windows
embedders who use a DLL interface for accessing Node.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes