Skip to content

tools: non-Ascii linter for /lib only#18043

Closed
SirR4T wants to merge 4 commits intonodejs:masterfrom
SirR4T:eslintForLib
Closed

tools: non-Ascii linter for /lib only#18043
SirR4T wants to merge 4 commits intonodejs:masterfrom
SirR4T:eslintForLib

Conversation

@SirR4T
Copy link
Copy Markdown

@SirR4T SirR4T commented Jan 8, 2018

Non-ASCII characters in /lib get compiled into the node binary,
and may bloat the binary size unnecessarily. A linter rule may
help prevent this.

Fixes: #11209

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

eslint

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linter rule: use ASCII quotes not Unicode ones

7 participants