Skip to content

Converting test to use Countdown#17505

Closed
TomerOmri wants to merge 9 commits intonodejs:masterfrom
TomerOmri:countdown
Closed

Converting test to use Countdown#17505
TomerOmri wants to merge 9 commits intonodejs:masterfrom
TomerOmri:countdown

Conversation

@TomerOmri
Copy link
Copy Markdown

@TomerOmri TomerOmri commented Dec 6, 2017

Hi,
this is my first PR :)
I worked on test-http-should-keep-alive.js
Ref: #17169

#Goodness squad

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants