Skip to content

lib: remove _debugger.js#12495

Closed
bnoordhuis wants to merge 2 commits intonodejs:masterfrom
bnoordhuis:remove-lib-debugger
Closed

lib: remove _debugger.js#12495
bnoordhuis wants to merge 2 commits intonodejs:masterfrom
bnoordhuis:remove-lib-debugger

Conversation

@bnoordhuis
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis commented Apr 18, 2017 •
edited
Loading

The file no longer works after the removal of the --debug/--debug-brk
switches in commit 47f8f74 ("src: remove support for --debug".)

This commit also removes several tests that still referenced the
old debugger but were either unit-testing its internals or passing
for the wrong reason (like expecting an operation to fail, which
it did because the debugger is gone.)

CI: https://ci.nodejs.org/job/node-test-pull-request/7497/

@bnoordhuis
lib,src,test: update --debug/debug-brk comments
f991f75 
Overlooked in commit 47f8f74 ("src: remove support for --debug") from
earlier this month.
@bnoordhuis
lib: remove _debugger.js
857dd1a 
The file no longer works after the removal of the --debug/--debug-brk
switches in commit 47f8f74 ("src: remove support for --debug".)

This commit also removes several tests that still referenced the
old debugger but were either unit-testing its internals or passing
for the wrong reason (like expecting an operation to fail, which
it did because the debugger is gone.)
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. debugger lib / src Issues and PRs related to general changes in the lib or src directory. module Issues and PRs related to the module subsystem. labels Apr 18, 2017
jasnell
jasnell approved these changes Apr 18, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing stuff is goodness.

@jasnell jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 18, 2017
@jasnell
Copy link
Copy Markdown
Member

jasnell commented Apr 18, 2017

Defensively flagging as semver-major. If it needed be, please remove the flag.

@gibfahn
Copy link
Copy Markdown
Member

gibfahn commented Apr 18, 2017

There is a request to re-add --debug-brk in master and Node 8: #12364, which would presumably mean that we'd have to keep the --debug-brk bits.

@bnoordhuis
Copy link
Copy Markdown
Member Author

bnoordhuis commented Apr 18, 2017

What I've removed is all dead code. I was aware of #12364 so I left in the --debug and --debug-brk handling logic in lib/internal/cluster.js.

Whoever is going to pick up that issue should look closely at that file and the NODE_DEBUG_ENABLED logic in particular.

cjihrig
cjihrig approved these changes Apr 18, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👋

@bnoordhuis bnoordhuis closed this Apr 21, 2017
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 21, 2017
@bnoordhuis
lib,src,test: update --debug/debug-brk comments
e0b076a 
Overlooked in commit 47f8f74 ("src: remove support for --debug") from
earlier this month.

PR-URL: nodejs#12495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Apr 21, 2017
@bnoordhuis
lib: remove _debugger.js
90476ac 
The file no longer works after the removal of the --debug/--debug-brk
switches in commit 47f8f74 ("src: remove support for --debug".)

This commit also removes several tests that still referenced the
old debugger but were either unit-testing its internals or passing
for the wrong reason (like expecting an operation to fail, which
it did because the debugger is gone.)

PR-URL: nodejs#12495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis
Copy link
Copy Markdown
Member Author

bnoordhuis commented Apr 21, 2017

For some reason the PR doesn't show up as merged but the relevant changes were landed in ee0620b...90476ac.

@TimothyGu TimothyGu mentioned this pull request Apr 21, 2017
Closed
3 tasks
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@bnoordhuis bnoordhuis mentioned this pull request Jun 19, 2017
Closed
2 tasks
@cjihrig cjihrig mentioned this pull request Sep 27, 2018
Merged
2 tasks
cjihrig added a commit to cjihrig/node that referenced this pull request Oct 1, 2018
@cjihrig
cluster: move handle tracking out of utils
47a0a0b 
internal/cluster/utils.js exported a handles object, which was
used in a test. That test, test-cluster-disconnect-handles.js,
was removed in nodejs#12495. This
commit moves the handles object to the only file in the codebase
that still uses it.

PR-URL: nodejs#23131
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 1, 2018
@cjihrig @targos
cluster: move handle tracking out of utils
26ba077 
internal/cluster/utils.js exported a handles object, which was
used in a test. That test, test-cluster-disconnect-handles.js,
was removed in #12495. This
commit moves the handles object to the only file in the codebase
that still uses it.

PR-URL: #23131
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 3, 2018
@cjihrig @targos
cluster: move handle tracking out of utils
54ca0e1 
internal/cluster/utils.js exported a handles object, which was
used in a test. That test, test-cluster-disconnect-handles.js,
was removed in #12495. This
commit moves the handles object to the only file in the codebase
that still uses it.

PR-URL: #23131
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. module Issues and PRs related to the module subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bnoordhuis @jasnell @gibfahn @cjihrig @nodejs-github-bot