fix: prevent heading and def tokens from greedily capturing multiple newlines#3925
fix: prevent heading and def tokens from greedily capturing multiple newlines#3925Puxhkar wants to merge 1 commit intomarkedjs:masterfrom
Conversation
|
@servis is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the tokenization process in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I will have to test this against a couple extensions. This could be a breaking change. |
Good point, thanks for calling that out. I’ll test this with a few extensions and edge cases (especially ones that rely on Let me know if there are any specific extensions you’d like me to check as well. |
|
I looked at a few extensions that use the tokens and I don't see any that would break due to this change, but I still think we should consider this a breaking change since it is not really a fix. If we want to be consistent we should also make html blocks and indented code blocks do the same thing. |
…nitions
Marked version:
Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.