fix(cli): honor positional input file#3922
fix(cli): honor positional input file#3922Nandann018-ux wants to merge 1 commit intomarkedjs:masterfrom
Conversation
|
@Nandann018-ux is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where the CLI would ignore a positional input file and read from stdin instead. The change correctly adjusts the logic to prioritize input from the --string option, then a positional file argument, and finally stdin. A unit test has been added to verify the fix for positional arguments. My feedback includes a suggestion to make the new test more robust by verifying that it's specifically the last positional argument that is used, as per the intended logic.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@calculuschild @styfle can u pls review my pr |
|
@UziTech can you please get my pr merged? |
Marked version:
17.0.5
Markdown flavor: n/a
Description
marked README.mdshould parse the file.marked README.mdwaits on stdin or emits empty output unless stdin is provided.getDataalways preferred stdin when no--input.--string, then the last positional argument as input file, and fall back to stdin only when no inputs exist.npm run build,npm run test:unitContributor
Committer