Clarify why GIT_PYTHON_GIT_EXECUTABLE may be set on failure#1810
Merged
Byron merged 2 commits intogitpython-developers:mainfrom Jan 24, 2024
Merged
Clarify why GIT_PYTHON_GIT_EXECUTABLE may be set on failure#1810Byron merged 2 commits intogitpython-developers:mainfrom
Byron merged 2 commits intogitpython-developers:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1804
This clarifies the comment that explains the significance of setting the
Git.GIT_PYTHON_GIT_EXECUTABLEattribute when running Git failed but the attribute wasn't set before.This happens in the code path in
Git.refreshwherehas_gitisFalseandold_gitisNone, provided the refresh mode doesn't call for the initial refresh to raise an exception on failure.It was previously described in terms of a "first" and "second" import, but as discussed in #1804, the rationale and effect were not altogether clear. This uses wording along the lines of what I suggested there, adjusted a bit for context.