refactor: rename tools/core/ to tools/shared/ and remove barrel re-exports#497
Closed
jirispilka wants to merge 1 commit intofeat/tool-mode-core-extractionfrom
Closed
refactor: rename tools/core/ to tools/shared/ and remove barrel re-exports#497jirispilka wants to merge 1 commit intofeat/tool-mode-core-extractionfrom
jirispilka wants to merge 1 commit intofeat/tool-mode-core-extractionfrom
Conversation
…ports - Rename src/tools/core/ → src/tools/shared/ for a clearer name that reflects the actual intent (mode-agnostic logic shared across variants) - Remove re-export shims from actor.ts that proxied core/ symbols - Update tools/index.ts to import directly from shared/ instead of routing through actor.ts - Update all import sites: server.ts, actor.ts, index.ts, and unit test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #466 addressing two review comments:
src/tools/core/→src/tools/shared/—core/is too vague and doesn't describe what the directory actually contains.shared/communicates the real intent: mode-agnostic logic that is shared across tool variants, without any UI/presentation concerns.actor.ts— the backward-compat re-exports added in refactor: extract shared core logic into src/tools/core/ modules #466 created an unnecessary indirection layer.tools/index.tsnow imports directly fromshared/, andactor.tsno longer proxies symbols it doesn't own.Changes
src/tools/core/→src/tools/shared/src/tools/actor.tssrc/tools/index.tsshared/instead of viaactor.tssrc/mcp/server.tstests/unit/tools.structured-output-schemas.test.tsVerification
🤖 Generated with Claude Code