Skip to content

Fix rest service port conflicts bug#17401

Open
JackieTien97 wants to merge 1 commit intomasterfrom
ty/ci-unreliable
Open

Fix rest service port conflicts bug#17401
JackieTien97 wants to merge 1 commit intomasterfrom
ty/ci-unreliable

Conversation

@JackieTien97
Copy link
Copy Markdown
Contributor

This pull request contains several test simplifications and a minor bug fix. The most significant changes are the simplification of test cases by removing unnecessary loops in the IoTDBUncorrelatedInPredicateSubqueryIT integration test, a bug fix in the construction of the REST service port in the DataNodeWrapper, and an improvement to error handling in the MemoryPool class.

Test simplification:

  • Simplified the testInPredicateSubqueryInHavingClause test method in IoTDBUncorrelatedInPredicateSubqueryIT by removing redundant loops over NUMERIC_MEASUREMENTS and directly calling tableResultSetEqualTest with the SQL and expected results. This makes the test code cleaner and easier to maintain. [1] [2] [3]

Bug fix:

  • Fixed the assignment of the restServicePort in DataNodeWrapper to use portList[7] instead of an incorrect calculation, ensuring the correct port is used for the REST service.

Error handling improvement:

  • Improved the error message in MemoryPool.free to include the original NullPointerException as the cause, making debugging easier.

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 39.80%. Comparing base (b49aaac) to head (827f03d).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...db/db/queryengine/execution/memory/MemoryPool.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17401      +/-   ##
============================================
- Coverage     39.80%   39.80%   -0.01%     
  Complexity      312      312              
============================================
  Files          5127     5127              
  Lines        346357   346357              
  Branches      44116    44116              
============================================
- Hits         137859   137856       -3     
- Misses       208498   208501       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant