Skip to content

Pipe: Fixed some potential OPC UA problems & Added IT for `` in opc#17393

Open
Caideyipi wants to merge 5 commits intomasterfrom
opc-small-fix
Open

Pipe: Fixed some potential OPC UA problems & Added IT for `` in opc#17393
Caideyipi wants to merge 5 commits intomasterfrom
opc-small-fix

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

@Caideyipi Caideyipi commented Mar 30, 2026

Description

  1. Fixed the potential resource leak of the input & output stream in OpcUaKeyStoreLoader
  2. Optimized the error logic for incorrect password in KeyStoreLoader
  3. Added some comments for policy set
  4. Optimized the shutdown logic of OpcUaNameSpace
  5. Added IT for `` in OPC

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.80%. Comparing base (e4fad59) to head (660d6a6).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ink/protocol/opcua/server/OpcUaKeyStoreLoader.java 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17393      +/-   ##
============================================
+ Coverage     39.77%   39.80%   +0.03%     
  Complexity      312      312              
============================================
  Files          5127     5127              
  Lines        346355   346395      +40     
  Branches      44113    44121       +8     
============================================
+ Hits         137777   137898     +121     
+ Misses       208578   208497      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Caideyipi Caideyipi changed the title Pipe: Fixed some potential OPC UA problems Pipe: Fixed some potential OPC UA problems & Added IT for `` in opc Mar 31, 2026
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant