Hide inactive offerings from User type accounts#12865
Hide inactive offerings from User type accounts#12865erikbocks wants to merge 4 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12865 +/- ##
============================================
- Coverage 18.02% 18.02% -0.01%
- Complexity 16450 16451 +1
============================================
Files 5968 5968
Lines 537086 537090 +4
Branches 65961 65962 +1
============================================
- Hits 96819 96818 -1
- Misses 429347 429350 +3
- Partials 10920 10922 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the UI “Compute Offerings” listing configuration so User accounts don’t see inactive offerings and don’t get a state filter dropdown, while Admin/DomainAdmin behavior remains unchanged.
Changes:
- For
computeoffering, default API params now forcestate=Activefor non-admin roles. computeofferingfilter options are now role-aware (state filter hidden for Users).computeofferingtable columns were adjusted (GPU column removed).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b01ae39 to
9055136
Compare
Co-authored-by: Fabricio Duarte <fabricio.duarte.jr@gmail.com>
|
@erikbocks , if I read the code correctly this will only select active offerings for normal users and not really hide them. Should we implement this filter in the API instead of the UI? Or is there a reason users should still be able to list them? |
Description
This PR changes the compute offerings tab behavior to prevent the listing of inactive offerings to User type accounts.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
Logged in as the ROOT admin, I validated that the compute offerings' listing displayed the filter button, and allowed the listing of
ActiveandInactiveofferings. Then, I logged in with aUsertype account, and validated that the state filter button was hidden, and onlyActiveofferings were listed.